Repository navigation
Bump minimatch from 10.2.6 to 11.0.1 in /client - #1935
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.2.6...v11.0.1) --- updated-dependencies: - dependency-name: minimatch dependency-version: 11.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The minimatch 11 upgrade leaves two calls to the removed Minimatch.makeRe() API, breaking TypeScript compilation and causing runtime failures in file-operation registration and glob matching.
1 open issue
1 file not reviewed
client/package-lock.json: Generated file
What changed in this PR
Updates the VS Code language client’s minimatch dependency from 10.2.6 to 11.0.1.
Changes:
- Raises the client dependency range to
^11.0.1. - Updates the lockfile and adds
@isaacs/nonrecursive-glob-matchas a transitive dependency.
Builds and tests were not run.
| File | Description |
|---|---|
client/package.json |
Updates the minimatch dependency range. |
client/package-lock.json |
Locks minimatch 11.0.1 and updates its dependency metadata. |
Review effort: Balanced
| }, | ||
| "dependencies": { | ||
| "minimatch": "^10.2.6", | ||
| "minimatch": "^11.0.1", |
|
Raymond Zhao (@rzhao271) have you seen this problem somewhere else? |
There was a problem hiding this comment.
🔵 Needs a closer look
The minimatch 11 upgrade removes makeRe(), which two existing callers still use, breaking TypeScript compilation and causing runtime failures in file-operation filters and glob matching.
1 open issue
1 file not reviewed
client/package-lock.json: Generated file
Review effort: Balanced
## Motivation Two Dependabot alerts cannot be fixed automatically: - `@azure/msal-node` [GHSA-xcx6-jx8p-x3h5](GHSA-xcx6-jx8p-x3h5) (fixed in 7.1.0), pulled in by `@vscode/vsce` and `ovsx` through `@azure/identity@4.13.3`. - `minimatch` [GHSA-g3hv-75wg-m249](GHSA-g3hv-75wg-m249) (affects `>=7.0.0 <11.0.1`, no fixed 10.x release). ## Changes - Update `@azure/identity` in the lockfile to 4.14.1. It depends on `@azure/msal-node` `^7.1.0`, so `@azure/msal-node` is now 7.2.1. This fixes the msal-node alert without changing any version range in `package.json`. - Update `@vscode/vsce` from `^3.6.0` to `^4.1.0`. `ovsx@1.3.0` already depends on vsce 4, so two vsce trees were installed. vsce 4 needs Node.js 22 or later (CI uses 24). It replaces glob with tinyglobby and no longer depends on `keytar`, so `keytar` is removed from `allowBuilds`. The lockfile loses about 1,000 lines. - Remove `src/test/suite/index.ts`. It is the old Mocha runner from before `@vscode/test-cli`, and `.vscode-test.mjs` does not use it. The root `glob` dev dependency was only used there, so it is removed too. - TypeScript 7 defaults `types` to `[]`. The removed runner's `import Mocha from 'mocha'` was what loaded the Mocha globals (`suite`, `test`) for the other test files, so `tsconfig.json` now lists `mocha` and `node` in `types`. No CHANGELOG entry, as this is an internal change. ## Notes: minimatch alert stays open This PR does not fix the minimatch alert, and it cannot be fixed with an `overrides` entry: - `vscode-languageclient` (10.1.2, and also the latest 11.0.0) depends on `minimatch ^10.2.6` and calls `Minimatch#makeRe()`. minimatch 11 removes `makeRe()`, so forcing 11 would throw a `TypeError` at runtime in the bundled extension. Upstream tracks this in `microsoft/vscode-languageserver-node#1938` (the fix PR `microsoft/vscode-languageserver-node#1935` currently fails CI). - glob 10 and 13 (via mocha, `@vscode/test-cli` and `test-exclude`) need glob 14 for minimatch 11, so the dev tools would need several more overrides. The alert would still stay open because of `vscode-languageclient`. The vulnerable code (`firstPhasePreProcess`) only runs with `optimizationLevel >= 2`. `vscode-languageclient` uses the default level 1, and its patterns come from the R language server. glob uses level 2, but only with the repository's own test globs. Once `vscode-languageclient` releases a version on minimatch 11, the alert should be fixable with a normal update. ## Update: debugging extension tests The **Extension Tests** launch configuration in `.vscode/launch.json` still pointed at the removed runner (`out/test/suite/index`), so it could no longer run any tests. It now uses js-debug's `testConfiguration` option (VS Code 1.87+) with `.vscode-test.mjs`: - After the `pretest` pre-launch task, js-debug runs `vscode-test --list-configuration`, asks which configuration to run, and launches `@vscode/test-cli`'s own runner with that configuration's files, Mocha options and launch arguments. F5 debugging works as before, without a second hand-written runner or the `glob` dependency. - This is also more accurate than the old runner, which ran every `src/test/suite/` file in one window without `out/test/common/extensionSetup.js` or the per-suite profiles. - Unlike the CLI, it runs in the current VS Code and does not install extension dependencies, so R Syntax must already be installed. `CONTRIBUTING.md` says this. [Extension Test Runner](https://marketplace.visualstudio.com/items?itemName=ms-vscode.extension-test-runner) (`ms-vscode.extension-test-runner`) is added to the workspace recommendations as an optional way to run or debug individual tests from the Testing view. Neither the debugger nor the CLI requires it. The `sess-install-tasks` configuration is removed. Its only test (`src/test/integration/sessInstall.test.ts`) was removed in #1856, so it ran 0 tests. Its temporary workspace was also deleted on process exit, so it was gone when a separate `--list-configuration` process (as used by the debugger and Extension Test Runner) exited. ## Update: working-directory-independent test profiles Test profile directories in `.vscode-test.mjs` now resolve relative to the configuration file's `import.meta.url`, using `fileURLToPath` for native filesystem paths. js-debug can load the configuration from a working directory outside the checkout, including the VS Code installation directory on Windows. Profiles now consistently stay under the checkout's `.vscode-test/user-data` directory.
|
I fixed this in a separate PR. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
Dirk Bäumer (@dbaeumer) is there a release with this fix? (I couldn't find which PR you were referring above to see when it was merged). I was trying to add some Dependabot alerts that currently show this: A patched version exists for minimatch, but the available update path would downgrade vscode-languageclient from 11.0.0 to 9.0.1 because:
|

Bumps minimatch from 10.2.6 to 11.0.1.
Changelog
Sourced from minimatch's changelog.
... (truncated)
Commits
47afe8811.0.177a0f5climit **/.. optimization pass to avoid quadratic explosion6f9f13111.0.002dcbe4update oxlint47b5d1ahandle //?/UNC/host/share long UNC forms05bce27do not optimize out the windows rootba01806document that a / takes priority over extglob sectionse5c04b4correct 'partial' mode matching of multiple-** patternscff11d8compare UNC host/share case-insensitivelyc86670ebenchmark scriptsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.