Skip to content

Bump minimatch from 10.2.6 to 11.0.1 in /client - #1935

Closed
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/client/minimatch-11.0.1
Closed

dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/client/minimatch-11.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 31, 2026

Copy link
Copy Markdown
Contributor

Bumps minimatch from 10.2.6 to 11.0.1.

Changelog

Sourced from minimatch's changelog.

change log

11.0

  • Match each path portion with Matcher from @isaacs/nonrecursive-glob-match, in place of a RegExp. Items in Minimatch.set are now strings, Matcher objects, or GLOBSTAR.
  • Remove makeRe(), Minimatch#regexp, and the MMRegExp type.
  • Remove the AST class.
  • Remove the maxExtglobRecursion option.
  • An empty path portion, such as the last one in a/b/, only matches an empty pattern portion. So a/b/ no longer matches a/b/?(x) or a/b/*(x), the same as a/b/*.
  • Add the normalize option, to normalize unicode in the pattern and in each portion of the tested path.
  • Remove the debug option and the debug() method.
  • Remove the matchOne(), slashSplit(), and levelTwoFileOptimize() methods. They are internal now.
  • Fix patterns with more than one ** and sections of different lengths between them, such as **/a/b/c/**/d/**, which failed to match some paths since 10.2.3.
  • Fix partial matching of patterns with **, which since 10.2.3 matched some paths under a dot portion that ** can not walk, and did not match some paths that end in the pattern's last portion.
  • partial matching of patterns with many ** no longer takes exponential time.
  • On Windows, a .. no longer removes the drive letter, or the host and share of a UNC path, at the start of a pattern or (at optimization level 2) a path. So C:/a/../../x no longer matches x or /x.
  • On Windows, compare the host and share of UNC paths like //host/share/... case-insensitively, the same as drive letters.
  • On Windows, long UNC paths like //?/UNC/host/share/... match //host/share/... and vice versa, the same as //?/c:/... and c:/....
  • At optimization level 2, stop splitting **/.. portions once there are braceExpandMax patterns, and do not dedupe sets of more than 1000 patterns. Before, a short pattern could take minutes to compile.
  • minimatch() keeps the 256 Minimatch objects that it used most recently, so it does not compile the same pattern again.
  • Faster to compile brace patterns that make rows that are merged, such as **/*.{png,jpg,gif}, because the Matchers for the rows that are merged are not made.

10.2

... (truncated)

Commits
  • 47afe88 11.0.1
  • 77a0f5c limit **/.. optimization pass to avoid quadratic explosion
  • 6f9f131 11.0.0
  • 02dcbe4 update oxlint
  • 47b5d1a handle //?/UNC/host/share long UNC forms
  • 05bce27 do not optimize out the windows root
  • ba01806 document that a / takes priority over extglob sections
  • e5c04b4 correct 'partial' mode matching of multiple-** patterns
  • cff11d8 compare UNC host/share case-insensitively
  • c86670e benchmark scripts
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.2.6...v11.0.1)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 11.0.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Copilot AI balanced review requested due to automatic review settings October 31, 2026 02:43
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The minimatch 11 upgrade leaves two calls to the removed Minimatch.makeRe() API, breaking TypeScript compilation and causing runtime failures in file-operation registration and glob matching.

1 open issue
1 file not reviewed
  • client/package-lock.json: Generated file
What changed in this PR

Updates the VS Code language client’s minimatch dependency from 10.2.6 to 11.0.1.

Changes:

  • Raises the client dependency range to ^11.0.1.
  • Updates the lockfile and adds @isaacs/nonrecursive-glob-match as a transitive dependency.

Builds and tests were not run.

File Description
client/​package.json Updates the minimatch dependency range.
client/​package-lock.json Locks minimatch 11.0.1 and updates its dependency metadata.

Review effort: Balanced

Comment thread client/package.json
},
"dependencies": {
"minimatch": "^10.2.6",
"minimatch": "^11.0.1",
@dbaeumer

Copy link
Copy Markdown
Member

Raymond Zhao (@rzhao271) have you seen this problem somewhere else?

Copilot AI balanced review requested due to automatic review settings November 3, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The minimatch 11 upgrade removes makeRe(), which two existing callers still use, breaking TypeScript compilation and causing runtime failures in file-operation filters and glob matching.

1 open issue
1 file not reviewed
  • client/package-lock.json: Generated file

Review effort: Balanced

eitsupi added a commit to REditorSupport/vscode-R that referenced this pull request Nov 9, 2026
## Motivation

Two Dependabot alerts cannot be fixed automatically:

- `@azure/msal-node` [GHSA-xcx6-jx8p-x3h5](GHSA-xcx6-jx8p-x3h5) (fixed in 7.1.0), pulled in by `@vscode/vsce` and `ovsx` through `@azure/identity@4.13.3`.
- `minimatch` [GHSA-g3hv-75wg-m249](GHSA-g3hv-75wg-m249) (affects `>=7.0.0 <11.0.1`, no fixed 10.x release).

## Changes

- Update `@azure/identity` in the lockfile to 4.14.1. It depends on `@azure/msal-node` `^7.1.0`, so `@azure/msal-node` is now 7.2.1. This fixes the msal-node alert without changing any version range in `package.json`.
- Update `@vscode/vsce` from `^3.6.0` to `^4.1.0`. `ovsx@1.3.0` already depends on vsce 4, so two vsce trees were installed. vsce 4 needs Node.js 22 or later (CI uses 24). It replaces glob with tinyglobby and no longer depends on `keytar`, so `keytar` is removed from `allowBuilds`. The lockfile loses about 1,000 lines.
- Remove `src/test/suite/index.ts`. It is the old Mocha runner from before `@vscode/test-cli`, and `.vscode-test.mjs` does not use it. The root `glob` dev dependency was only used there, so it is removed too.
- TypeScript 7 defaults `types` to `[]`. The removed runner's `import Mocha from 'mocha'` was what loaded the Mocha globals (`suite`, `test`) for the other test files, so `tsconfig.json` now lists `mocha` and `node` in `types`.

No CHANGELOG entry, as this is an internal change.

## Notes: minimatch alert stays open

This PR does not fix the minimatch alert, and it cannot be fixed with an `overrides` entry:

- `vscode-languageclient` (10.1.2, and also the latest 11.0.0) depends on `minimatch ^10.2.6` and calls `Minimatch#makeRe()`. minimatch 11 removes `makeRe()`, so forcing 11 would throw a `TypeError` at runtime in the bundled extension. Upstream tracks this in `microsoft/vscode-languageserver-node#1938` (the fix PR `microsoft/vscode-languageserver-node#1935` currently fails CI).
- glob 10 and 13 (via mocha, `@vscode/test-cli` and `test-exclude`) need glob 14 for minimatch 11, so the dev tools would need several more overrides. The alert would still stay open because of `vscode-languageclient`.

The vulnerable code (`firstPhasePreProcess`) only runs with `optimizationLevel >= 2`. `vscode-languageclient` uses the default level 1, and its patterns come from the R language server. glob uses level 2, but only with the repository's own test globs. Once `vscode-languageclient` releases a version on minimatch 11, the alert should be fixable with a normal update.


## Update: debugging extension tests

The **Extension Tests** launch configuration in `.vscode/launch.json` still pointed at the removed runner (`out/test/suite/index`), so it could no longer run any tests. It now uses js-debug's `testConfiguration` option (VS Code 1.87+) with `.vscode-test.mjs`:

- After the `pretest` pre-launch task, js-debug runs `vscode-test --list-configuration`, asks which configuration to run, and launches `@vscode/test-cli`'s own runner with that configuration's files, Mocha options and launch arguments. F5 debugging works as before, without a second hand-written runner or the `glob` dependency.
- This is also more accurate than the old runner, which ran every `src/test/suite/` file in one window without `out/test/common/extensionSetup.js` or the per-suite profiles.
- Unlike the CLI, it runs in the current VS Code and does not install extension dependencies, so R Syntax must already be installed. `CONTRIBUTING.md` says this.

[Extension Test Runner](https://marketplace.visualstudio.com/items?itemName=ms-vscode.extension-test-runner) (`ms-vscode.extension-test-runner`) is added to the workspace recommendations as an optional way to run or debug individual tests from the Testing view. Neither the debugger nor the CLI requires it.

The `sess-install-tasks` configuration is removed. Its only test (`src/test/integration/sessInstall.test.ts`) was removed in #1856, so it ran 0 tests. Its temporary workspace was also deleted on process exit, so it was gone when a separate `--list-configuration` process (as used by the debugger and Extension Test Runner) exited.

## Update: working-directory-independent test profiles

Test profile directories in `.vscode-test.mjs` now resolve relative to the configuration file's `import.meta.url`, using `fileURLToPath` for native filesystem paths. js-debug can load the configuration from a working directory outside the checkout, including the VS Code installation directory on Windows. Profiles now consistently stay under the checkout's `.vscode-test/user-data` directory.
@dbaeumer

Copy link
Copy Markdown
Member

I fixed this in a separate PR.

@dependabot @github

dependabot Bot commented on behalf of github Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/client/minimatch-11.0.1 branch November 9, 2026 11:59
@DanTup

Copy link
Copy Markdown
Contributor

Dirk Bäumer (@dbaeumer) is there a release with this fix? (I couldn't find which PR you were referring above to see when it was merged).

I was trying to add some Dependabot alerts that currently show this:

A patched version exists for minimatch, but the available update path would downgrade vscode-languageclient from 11.0.0 to 9.0.1 because:
The following packages currently require minimatch through these dependency edges:

  • vscode-languageclient: requires minimatch@^10.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants